Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problems when starting debug from status line #37507

Closed
weinand opened this issue Nov 2, 2017 · 2 comments
Closed

Problems when starting debug from status line #37507

weinand opened this issue Nov 2, 2017 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@weinand
Copy link
Contributor

weinand commented Nov 2, 2017

When the launch config is run from the status bar:

  • no launch config errors show up, e.g. if the debug type is wrong or if 'request' attribute is missing
  • the same launch config can be started multiple times

I suggest to use the identical code for launching from the status line and through the debug drop down menu.

@weinand weinand added bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues labels Nov 2, 2017
@isidorn isidorn added this to the November 2017 milestone Nov 2, 2017
@isidorn isidorn closed this as completed in bf2f921 Nov 8, 2017
@isidorn
Copy link
Contributor

isidorn commented Nov 8, 2017

One is an action, and the other is a quick open item entry. Due to that it is not very trivial to share an implementation. THough I have tried to sharae by introducing a statis isEnabled

@weinand
Copy link
Contributor Author

weinand commented Dec 5, 2017

Verified ok but I've created #39707 to improve the weak UI.

@weinand weinand added the verified Verification succeeded label Dec 5, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants