Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad MessageWidget position on wrapped line #37568

Closed
mjbvz opened this issue Nov 3, 2017 · 3 comments
Closed

Bad MessageWidget position on wrapped line #37568

mjbvz opened this issue Nov 3, 2017 · 3 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug editor-contrib Editor collection of extras verified Verification succeeded
Milestone

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Nov 3, 2017

Steps to Reproduce:

  1. Open the settings editor
  2. On the left hand side, find a long setting description that wraps to multiple lines
  3. Place the cursor on one of the wrapped lines
  4. Try typing

Bug

screen shot 2017-11-02 at 5 30 22 pm

Warning is shown in the correct column but on the first line of the wrapped line

@bpasero
Copy link
Member

bpasero commented Nov 3, 2017

I am using the MessageWidget from @jrieken so I would assume the same issue when the "No Definitions" info message pops up.

@bpasero bpasero assigned jrieken and unassigned bpasero Nov 3, 2017
@jrieken
Copy link
Member

jrieken commented Nov 3, 2017

@alexandrudima The MessageWidget is implemented as IContentWidget which provided its position as model-position, not viewModel-position. Is there a better widget that works with wrapped lines?

@jrieken jrieken changed the title Readonly settings warning always shows on first line of wrapped line Bad MessageWidget position on wrapped line Nov 3, 2017
@jrieken jrieken added bug Issue identified by VS Code Team member as probable bug editor-contrib Editor collection of extras labels Nov 3, 2017
@alexdima
Copy link
Member

alexdima commented Nov 3, 2017

The IContentWidget position is converted to view model coordinates before being painted.

See the suggest widget which is an IContentWidget and works correctly for wrapped text AFAIK.

So I would assume a correct model position will result in a correct view position.

@jrieken jrieken added this to the November 2017 milestone Nov 3, 2017
@mjbvz mjbvz added the verified Verification succeeded label Dec 6, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug editor-contrib Editor collection of extras verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants