-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
enter inside html element doesn't add two lines with indented cursor in between #38101
Comments
As for me, now it's more comfortable despite of it's unusual |
@antony-chopin Not sure I understand your comment? At least for me all the other competing editors have the feature of when the cursor is in between the div, p, h1, etc tag they will add add an indented line for content and then push the closing tag underneath the indented line. Now I have mainly tested this in laravel blade files, but have noticed a plain html page does in fact add the indent. |
@AnthonyMichaelc Yea, I'm about it. In my case, there is a lot of situations, when I need to add an extra wrapper for already existing group of tags (I'm React developer, so it's usual :D). Before I had to enter the wrapper, then select existing tags and press |
@antony-chopin That totally makes sense. I decided to contact the person who created the laravel blade syntax because it seems in my case blade syntax and vscode are not communicating properly. Cause for me I have to click enter twice then arrow up and hit tab which adds multiple steps that the other editors do in one click. |
I suppose, the best way to solve this problem is to allow user to set up whether he wants to add additional line on enter or not. |
Yes, after testing further into the issue I decided to contact the person who made the blade syntax extension. Sadly they have not looked at it. |
Thanks, closing the issue then. |
This issue may need to be reopened. I have contacted the team who is working on blade extension and everything they suggested is has not worked. More importantly I have tried every blade syntax extension in the marketstore. Is it possible that there is an issue in vscode/the out of the box emmet extension processing php/blade syntax?
When I search emmet in the market tab I do not see any extension there or anywhere to see if there is configurations that have changed, which could cause this issue with php frameworks. this is all the emmet configurations that are on my current install of vscode:
Unfortunately, this issue is making me and a good amount of the laravel/php people have to use other editors. Would like to get this working. |
@aeschli the behaviour displayed on GIF sometimes doesn't work in JSX files (thank God it doesn't :D) |
@antony-chopin I see that. For me, when I was working with jsx files I did not see a problem. Now i don't work with jsx files so I have removed the configuration for jsx. However, I am noticing with any blade syntax (which is lsrsvel/php) I am having this issue. I saw there was an issue similar to mine that has still not been resolved and they were saying that it may be an issue with vscode's handling of php and emmet and the indent. [ https://github.com/onecentlin/laravel-blade-snippets-vscode/issues/9 ]. |
Steps to Reproduce:
<p></p>
In most other editors if my cursor is inside of
<p></p>
and I hit enter, it will leave the<p>
and then add a line with indent and then add a third line with the</p>
My personal settings don't have anything on this but I am not sure if there is a user setting (what it would be referenced as.) Without this feature, I have to arrow up and over, hit enter again, and then hit tab to indent
The text was updated successfully, but these errors were encountered: