Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"typescript.useCodeSnippetsOnMethodSuggest" #38318

Closed
ghost opened this issue Nov 14, 2017 · 3 comments
Closed

"typescript.useCodeSnippetsOnMethodSuggest" #38318

ghost opened this issue Nov 14, 2017 · 3 comments
Assignees
Labels
feature-request Request for new features or functionality javascript JavaScript support issues typescript Typescript support issues

Comments

@ghost
Copy link

ghost commented Nov 14, 2017

  • VSCode Version: 1.18
  • OS Version: macOS

Steps to Reproduce:

  1. "typescript.useCodeSnippetsOnMethodSuggest": true
  2. Write JSON.parse and you will get suggestion and press Tab/Enter
  3. It will be autocompleted to JSON.parse(text, reviver)

That autocomplete doesn't select all params you need to use Tab to move between them and you're almost always using JSON.parse without last param only with first one text. My suggestion is to make it or add new setting which will select all params when it autocompletes function, etc.

You write JSON.parse press Tab/Enter it will be autocompleted to JSON.parse(text, reviver) and text starting from ( will be selected to the end of ).

WHY?

Because it is way easier to delete all params including , instead of moving with Tab or selecting text with mouse. This feature will make coding a lot easier.

Thanks!

P.S. This will apply to all functions, not only JSON.parse it was only example!

@ghost
Copy link
Author

ghost commented Nov 14, 2017

@mjbvz I know you're familiar with this. Can you say your opinion? I really want this feature, maybe I can somehow help you to introduce it?

@mjbvz mjbvz self-assigned this Nov 14, 2017
@mjbvz mjbvz added feature-request Request for new features or functionality javascript JavaScript support issues typescript Typescript support issues labels Nov 14, 2017
@mjbvz
Copy link
Contributor

mjbvz commented Nov 14, 2017

I think this is generally the expected behavior. The bug here is that we are fill in the optional parameter in the first place. We should only fill in required parameters for useCodeSnippetsOnMethodSuggest

@ghost
Copy link
Author

ghost commented Nov 14, 2017

@mjbvz That makes sense, fill only required parameters. But I also like that behavior explained above (I saw it in Atom with Flow). BUT any of these will be waaaay better than it's right now. As always thanks @mjbvz! ❤️

@mjbvz mjbvz closed this as completed in e884f51 Nov 30, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality javascript JavaScript support issues typescript Typescript support issues
Projects
None yet
Development

No branches or pull requests

2 participants