Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Files are intermingled #38331

Closed
alexdima opened this issue Nov 14, 2017 · 2 comments
Closed

Files are intermingled #38331

alexdima opened this issue Nov 14, 2017 · 2 comments
Assignees
@jrieken
Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Milestone
November 2017

Comments

@alexdima
Copy link
Member

  • open checker.ts in the left-hand-side editor
  • open user settings in the right-hand-side editor
  • close and start again vscode
  • The contents are intermingled:

image
@alexdima alexdima added the important Issue identified as high-priority label Nov 14, 2017
@jrieken jrieken added the bug Issue identified by VS Code Team member as probable bug label Nov 14, 2017
@jrieken jrieken added this to the November 2017 milestone Nov 14, 2017
@jrieken
Copy link
Member

jrieken commented Nov 14, 2017 •
edited

problem is that we use just 1 buffer. fix is to use a BufferPool

fyi @bpasero

@bpasero
Copy link
Member

bpasero commented Nov 15, 2017 •
edited

@alexandrudima wow great catch, I was so much into callback hell that I totally missed that issue when reviewing :-/

@mjbvz mjbvz added the verified Verification succeeded label Dec 6, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Dec 29, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
bug Issue identified by VS Code Team member as probable bug important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
4 participants
@bpasero @jrieken @alexdima @mjbvz