Defer RichEditBrackets creation #38659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjbvz
force-pushed
the
defer-RichEditBrackets-creation
branch
from
d1e7f97
to
a34efaf
Compare
alexdima
requested changes
Nov 24, 2017
| public readonly electricChars: { [key: string]: boolean; }; | ||
|
|
||
| private readonly _languageIdentifier: LanguageIdentifier; | ||
| private _electricChars: { [key: string]: boolean; }; |
There was a problem hiding this comment.
Small nit-pick: To avoid a hidden class mutation at runtime, I prefer to have all members initialized in the ctor. Can you please add this._electricChars = null;
| @@ -46,18 +46,20 @@ export interface IIndentConverter { | |||
| export class RichEditSupport { | |||
|
|
|||
| private readonly _conf: LanguageConfiguration; | |||
| private readonly _languageIdentifier: LanguageIdentifier; | |||
| private _brackets: RichEditBrackets; | |||
| private _electricCharacter: BracketElectricCharacterSupport; | |||
There was a problem hiding this comment.
Same as above.
Can you please add this._brackets = null; this._electricCharacter = null;
**Bug** `RichEditBrackets` are currently created eagerly pretty early in startup. This can be a fairly call as well. **fix** Lazily create `RichEditBrackets` instead
mjbvz
force-pushed
the
defer-RichEditBrackets-creation
branch
from
c4df90a
to
812128c
Compare
|
Nice! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug
RichEditBracketsare currently created eagerly pretty early in startupfix
Lazily create
RichEditBracketsinstead