Search: careful with path.basename()

[bpasero]

Careful when using path.basename, it can return an empty string depending on usage and depending on which basename method is used (there is a node.js one and a one in common from us).

node.js

• windows drive letter: empty string
• unix root: empty string

common

• windows drive letter: keeps the drive letter
• unix root: empty string

I am seeing some suspicious usages here and here.

Maybe do a general check for path.basename where a folder path is passed in as argument. This is not an issue for file paths obviously.