Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open File Handler now untildifies. Fixes #32736 #39122

Merged
merged 2 commits into from Nov 27, 2017

Conversation

moorejs
Copy link
Contributor

@moorejs moorejs commented Nov 25, 2017

This fixes issue #32736.

~/file.txt should now expand for Mac and Linux (e.g. to /Users/moorejs/file.txt), allowing you to quick open files by absolute filepath.

I believe I made the change in the best way, but feedback would be appreciated.

@msftclas
Copy link

msftclas commented Nov 25, 2017

CLA assistant check
All CLA requirements met.

Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, but I think it should work for Windows too. Powershell handles ~

Copy link
Member

@roblourens roblourens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks!

@roblourens roblourens merged commit c94ddce into microsoft:master Nov 27, 2017
@alexdima alexdima added this to the November 2017 milestone Dec 8, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants