Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autoclosing pair issue in VS code when dealing with multiple characters #39234

Closed
qutreson opened this issue Nov 28, 2017 · 0 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug

Comments

@qutreson
Copy link

VSCode Version: 1.18.1
OS Version: Win10

Steps to Reproduce:

  1. Write { "open": "begin", "close": "end", "notIn": ["string", "comment"] } as an auto closing pair
  2. Write a comment with "begin"

Expected: It does not close the pair by automatically writing "end".
Actual: It does close the comment by writing "end".

Reproduces without extensions: Yes

I tried the following auto closing pairs:

"autoClosingPairs": [
     // Those are not closing in comments
     { "open": "'", "close": "'", "notIn": ["string", "comment"] },
     { "open": "b", "close": "d", "notIn": ["string", "comment"] },
     { "open": "u", "close": "nn", "notIn": ["string", "comment"] },

     // Those are closing in comments even with "notIn"
     { "open": "nn", "close": "u", "notIn": ["string", "comment"] },
     { "open": "op", "close": "qo", "notIn": ["string", "comment"] },
     { "open": "begin", "close": "end", "notIn": ["string", "comment"] }
],

I think the problem here is that VS code does not handle properly pairs where the opening part has multiple characters.

@vscodebot vscodebot bot added the editor label Nov 28, 2017
@rebornix rebornix added the bug Issue identified by VS Code Team member as probable bug label Nov 29, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug
Projects
None yet
Development

No branches or pull requests

2 participants