Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window freezes when opening multiple dialogs #39527

Closed
bpasero opened this issue Dec 4, 2017 · 0 comments
Closed

Window freezes when opening multiple dialogs #39527

bpasero opened this issue Dec 4, 2017 · 0 comments
Assignees
Labels
freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Dec 4, 2017

Due to electron/electron#11323

Steps:

  • have an extension with the following code and run it:
'use strict';
// The module 'vscode' contains the VS Code extensibility API
// Import the module and reference it with the alias vscode in your code below
import * as vscode from 'vscode';

// this method is called when your extension is activated
// your extension is activated the very first time the command is executed
export function activate(context: vscode.ExtensionContext) {

    // Use the console to output diagnostic information (console.log) and errors (console.error)
    // This line of code will only be executed once when your extension is activated
    console.log('Congratulations, your extension "test-ts" is now active!');

    // The command has been defined in the package.json file
    // Now provide the implementation of the command with  registerCommand
    // The commandId parameter must match the command field in package.json
    let disposable = vscode.commands.registerCommand('extension.sayHello', () => {
        // The code you place here will be executed every time your command is executed

        // Display a message box to the user
        console.log(1)
        vscode.window.showSaveDialog({
        });
        setTimeout(() => {
            console.log(2)
            vscode.window.showInformationMessage("message", { modal: true });
        }, 1000);

    });

    context.subscriptions.push(disposable);
}

// this method is called when your extension is deactivated
export function deactivate() {
}

=> the window freezes

@bpasero bpasero added the freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues label Dec 4, 2017
@bpasero bpasero added this to the November 2017 milestone Dec 4, 2017
@bpasero bpasero self-assigned this Dec 4, 2017
@bpasero bpasero closed this as completed in 2fabfbd Dec 4, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 18, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
freeze-slow-crash-leak VS Code crashing, performance, freeze and memory leak issues
Projects
None yet
Development

No branches or pull requests

1 participant