Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Log Service: in renderer should also log via console.log #39577

Closed
bpasero opened this issue Dec 4, 2017 · 5 comments
Closed

Log Service: in renderer should also log via console.log #39577

bpasero opened this issue Dec 4, 2017 · 5 comments
Assignees
@joaomoreno @bpasero
Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workbench-diagnostics General VS Code built-in diagnostic issues
Milestone
November 2017

Comments

@bpasero
Copy link
Member

bpasero commented Dec 4, 2017

That allows us to use the log service as drop-in replacement for console.log/warning/error.
@bpasero bpasero added feature-request Request for new features or functionality workbench-diagnostics General VS Code built-in diagnostic issues labels Dec 4, 2017
@joaomoreno joaomoreno added this to the November 2017 milestone Dec 4, 2017
@joaomoreno
Copy link
Member

joaomoreno commented Dec 7, 2017 •
edited

Went ahead and implemented it. cc @bpasero

@bpasero bpasero added the verification-needed Verification of issue is requested label Dec 7, 2017
@bpasero
Copy link
Member Author

bpasero commented Dec 7, 2017

@joaomoreno cool! A bit odd that we now show this on every reload though:

image

@bpasero bpasero added the verified Verification succeeded label Dec 7, 2017
@joaomoreno
Copy link
Member

We can remove!

@bpasero
Copy link
Member Author

bpasero commented Dec 7, 2017

Done

@joaomoreno
Copy link
Member

Actually, not great, since it means the log file is empty by default which looks broken. Let's leave something smart in there. Like workbench started in 100ms.

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 21, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

@bpasero bpasero

Labels
feature-request Request for new features or functionality verification-needed Verification of issue is requested verified Verification succeeded workbench-diagnostics General VS Code built-in diagnostic issues
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
2 participants
@joaomoreno @bpasero