Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use classes for breakpoints #39639

Closed
jrieken opened this issue Dec 5, 2017 · 0 comments
Closed

Use classes for breakpoints #39639

jrieken opened this issue Dec 5, 2017 · 0 comments
Assignees
@weinand
Labels
api debug Debug viewlet, configurations, breakpoints, adapter issues
Milestone
November 2017

Comments

@jrieken
Copy link
Member

jrieken commented Dec 5, 2017

re #39553

I'd suggest to use classes for breakpoints. With that good old instanceof-checks can be used and the type-attribute isn't needed to differentiate. In case we still want/need a discriminating property we should use an enum instead of an or-type and call it kind (as we done in other cases)
@vscodebot vscodebot bot added the debug Debug viewlet, configurations, breakpoints, adapter issues label Dec 5, 2017
@weinand weinand added this to the November 2017 milestone Dec 5, 2017
@weinand weinand added the api label Dec 5, 2017
@weinand weinand closed this as completed in c70c818 Dec 6, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@weinand weinand

Labels
api debug Debug viewlet, configurations, breakpoints, adapter issues
Projects
None yet
Milestone
November 2017
Development

No branches or pull requests
2 participants
@jrieken @weinand