Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

automatic imports break when using flow type imports #39743

Closed
jlyons-bgl opened this issue Dec 6, 2017 · 1 comment
Closed

automatic imports break when using flow type imports #39743

jlyons-bgl opened this issue Dec 6, 2017 · 1 comment
Assignees
Labels
*extension-candidate Issue identified as good extension implementation javascript JavaScript support issues

Comments

@jlyons-bgl
Copy link

  • VSCode Version: 1.18.1
  • OS Version: macOS 10.12.6

The new automatic import feature is great! but I have an issue when using it with Flow.

starting with:

import { TAccount } from './TAccount'
import type { SimilarTransactionJson, TAccountJson } from '../../types/BankingTypes'

and selecting an auto import intelisense option I end up with:

import { TAccount } from './TAccount'
import typeimport { Entry } from './Entry';
 { SimilarTransactionJson, TAccountJson } from '../../types/BankingTypes'

Reproduces without extensions: Yes

@vscodebot vscodebot bot assigned mjbvz Dec 6, 2017
@vscodebot vscodebot bot added the javascript JavaScript support issues label Dec 6, 2017
@mjbvz
Copy link
Collaborator

mjbvz commented Dec 6, 2017

Yes, we don't provide built-in support for flow and cannot guarantee that our built-in js language support will not break flow specific syntax like import type. You can disable auto imports by setting: "typescript.autoImportSuggestions.enabled": false if this feature is getting in the way

@mjbvz mjbvz closed this as completed Dec 6, 2017
@mjbvz mjbvz added the *extension-candidate Issue identified as good extension implementation label Dec 6, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*extension-candidate Issue identified as good extension implementation javascript JavaScript support issues
Projects
None yet
Development

No branches or pull requests

2 participants