Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nuke the log-decorator #39806

Closed
jrieken opened this issue Dec 6, 2017 · 2 comments
Closed

Nuke the log-decorator #39806

jrieken opened this issue Dec 6, 2017 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@jrieken
Copy link
Member

jrieken commented Dec 6, 2017

re #39572

@log(LogLevel.Info, 'CommandService', (msg, id) => `${msg}(${id})`)
executeCommand<T>(id: string, ...args: any[]): TPromise<T> {
  // ..
}	

This looks very pretty and I believe it's a prime-sample for a decorator but once you wanna debug calls to executeCommand you will hate it. Really hate it. My recommendation is nuke it or not recommend it...

@vscodebot vscodebot bot added the debug Debug viewlet, configurations, breakpoints, adapter issues label Dec 6, 2017
@jrieken jrieken assigned joaomoreno and unassigned weinand Dec 6, 2017
@joaomoreno joaomoreno added this to the November 2017 milestone Dec 6, 2017
@joaomoreno joaomoreno added the bug Issue identified by VS Code Team member as probable bug label Dec 6, 2017
@joaomoreno
Copy link
Member

We nuke and treat it as a BUG!

@mjbvz mjbvz added the verified Verification succeeded label Dec 6, 2017
@mjbvz
Copy link
Contributor

mjbvz commented Dec 6, 2017

Verified no more @log in code and that logging still happen as expected

@weinand weinand removed the debug Debug viewlet, configurations, breakpoints, adapter issues label Dec 8, 2017
@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants