Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[c++] c++11 raw strings not highlighted properly #399

Closed
jepessen opened this issue Nov 21, 2015 · 7 comments
Closed

[c++] c++11 raw strings not highlighted properly #399

jepessen opened this issue Nov 21, 2015 · 7 comments
Assignees
@aeschli
Labels
bug Issue identified by VS Code Team member as probable bug languages-basic Basic language support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Milestone
Backlog

Comments

@jepessen
Copy link
Contributor

When I write a raw string in c++11 that span among many lines, it's not highlighted properly.

What I see:

raw-string-bad-highlighted

As you can see, raw string has not the string uniform color.
@aeschli
Copy link
Contributor

aeschli commented Nov 23, 2015

We use the text mate bundle from https://github.com/textmate/c.tmbundle which doesn't seem to support raw string.

@jepessen
Copy link
Contributor Author

Ok. If I try to modify it in order to support raw strings, then should I try to create a pull request for this repository, for the textmate one one or for both?

@aeschli
Copy link
Contributor

aeschli commented Nov 23, 2015

For both would be perfect. Otherwise it also works if you do it for text mate first and once accepted, I bring it over.

@jepessen
Copy link
Contributor Author

Ok I'll check when I'll have some time. Regards.

@aeschli aeschli changed the title c++11 raw strings not highlighted properly [c++] c++11 raw strings not highlighted properly Nov 24, 2015
@aeschli aeschli added help wanted Issues identified as good community contribution opportunities feature-request Request for new features or functionality labels Nov 25, 2015
@egamma egamma added the languages-basic Basic language support issues label Nov 30, 2015
@aeschli aeschli mentioned this issue Dec 9, 2015
Closed
@aeschli
Copy link
Contributor

aeschli commented Dec 9, 2015

This issue was moved to textmate/c.tmbundle#30

@aeschli aeschli closed this as completed Dec 9, 2015
@aeschli aeschli reopened this Dec 9, 2015
@aeschli aeschli added upstream Issue identified as 'upstream' component related (exists outside of VS Code) bug Issue identified by VS Code Team member as probable bug and removed help wanted Issues identified as good community contribution opportunities feature-request Request for new features or functionality labels Dec 9, 2015
@egamma egamma modified the milestone: Backlog Dec 10, 2015
@infininight
Copy link

This has been added to the TextMate repository, should be fixed next time the bundle is ported over.

@mjbvz
Copy link
Collaborator

mjbvz commented Nov 29, 2016

I believe this is fixed in 1.7+:

screen shot 2016-11-29 at 2 27 20 pm

@mjbvz mjbvz closed this as completed Nov 29, 2016
@ramya-rao-a ramya-rao-a added the verified Verification succeeded label Dec 7, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
bug Issue identified by VS Code Team member as probable bug languages-basic Basic language support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verified Verification succeeded
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
6 participants
@infininight @egamma @aeschli @mjbvz @jepessen @ramya-rao-a