Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open editors: drag image is not the same as explorer #40012

Closed
bpasero opened this issue Dec 11, 2017 · 4 comments
Closed

Open editors: drag image is not the same as explorer #40012

bpasero opened this issue Dec 11, 2017 · 4 comments
Assignees
Labels
file-explorer Explorer widget issues verification-needed Verification of issue is requested verified Verification succeeded workbench-dnd Drag-and-drop issues
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Dec 11, 2017

Steps to Reproduce:

  1. drag an editor from the open editors view

=> the drag image is not the same as the explorer where we show the name, instead we drag the entire list element it seems

@bpasero bpasero added file-explorer Explorer widget issues workbench-dnd Drag-and-drop issues labels Dec 11, 2017
@isidorn
Copy link
Contributor

isidorn commented Dec 11, 2017

@isidorn isidorn added this to the December 2017 milestone Dec 11, 2017
@isidorn isidorn added the verification-needed Verification of issue is requested label Dec 11, 2017
@joaomoreno
Copy link
Member

Why not bring this down to the list?

@isidorn
Copy link
Contributor

isidorn commented Dec 11, 2017

@joaomoreno i can do that. However the list would need to ask the client for the drag label. Should that be a part of list options or how would you like this?

@joaomoreno
Copy link
Member

joaomoreno commented Dec 11, 2017

Oh yeah forget it... we made it that the list user implements dnd, completely spaced out there. Never mind!

@vscodebot vscodebot bot locked and limited conversation to collaborators Jan 25, 2018
@bpasero bpasero added the verified Verification succeeded label Jan 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
file-explorer Explorer widget issues verification-needed Verification of issue is requested verified Verification succeeded workbench-dnd Drag-and-drop issues
Projects
None yet
Development

No branches or pull requests

3 participants