Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

massive leakage with search viewlet #4016

Closed
jrieken opened this issue Mar 11, 2016 · 3 comments
Closed

massive leakage with search viewlet #4016

jrieken opened this issue Mar 11, 2016 · 3 comments
Assignees
@jrieken
Labels
important Issue identified as high-priority verified Verification succeeded
Milestone
March 2016

Comments

@jrieken
Copy link
Member

jrieken commented Mar 11, 2016

  • Set up a workspace as outlined here: tsserver crashes with large projects TypeScript#7444
  • show search viewlet, search for bab once, wait for results, clear results
  • take a heap snapshot
  • search again for bab, when done press refresh, repeat 5 time
  • clear results
  • take another snapshot, heap grew by ~30MB
@jrieken
Copy link
Member Author

jrieken commented Mar 11, 2016

It's the file matches that leak cos they are referenced by the remove action which seems to be referenced via the action bar...

Archive 2.zip

@jrieken jrieken added the important Issue identified as high-priority label Mar 11, 2016
@jrieken jrieken changed the title leakage with search viewlet massive leakage with search viewlet Mar 11, 2016
@jrieken
Copy link
Member Author

jrieken commented Mar 11, 2016

Problem seems to be that ActionRunner@11221 get more and more listeners registered without ever unregistering...

@bpasero bpasero added this to the March 2016 milestone Mar 11, 2016
@bpasero bpasero assigned jrieken and unassigned bpasero Mar 16, 2016
@bpasero
Copy link
Member

bpasero commented Mar 16, 2016

Looked into this with Joao and it turns out that every call to Tree.setInput() would not clean up templates for rows created from the previous run. Specifically the cleanupFn is not being called which actually is the one to dispose the action bar used on each row.

@jrieken jrieken added the verified Verification succeeded label Mar 21, 2016
@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 18, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jrieken jrieken

Labels
important Issue identified as high-priority verified Verification succeeded
Projects
None yet
Milestone
March 2016
Development

No branches or pull requests
2 participants
@bpasero @jrieken