Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Operating system specific args don't override args defined in the task #40905

Closed
tiagovcosta opened this issue Dec 28, 2017 · 1 comment
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded

Comments

@tiagovcosta
Copy link

  • VSCode Version: Code 1.19.1 (0759f77, 2017-12-19T09:35:14.671Z)
  • OS Version: Darwin x64 17.3.0
  • Extensions:
Extension Author (truncated) Version
vscode-eslint dba 1.4.3
tslint eg2 1.0.24
python ms- 0.9.1
cpptools ms- 0.14.5
debugger-for-chrome msj 4.0.0
cmake twx 0.0.17

Using the task below:

{
            "label": "build test",
            "type": "shell",
            "options": {
                "cwd": "${workspaceRoot}/build/debug"
            },
            "command": "make",
            "args": [
                "-j", "8"
            ],
            "osx": {
                "command": "xcodebuild build",
                "args": ["oops"],
            },
            "problemMatcher": {
                "owner": "cpp",
                "fileLocation": [
                    "absolute"
                ],
                "pattern": {
                    "regexp": "^(.*):(\\d+):(\\d+):\\s+(warning|error|fatal error):\\s+(.*)$",
                    "file": 1,
                    "line": 2,
                    "column": 3,
                    "severity": 4,
                    "message": 5
                }
            },
            "group": "build"
}

If I run it on MacOS, the command xcodebuild build -j 8 oops is executed instead of the expected xcodebuild build oops (as described in the docs)

Looks like platform specific args are being appended instead of overriding.

Reproduces without extensions: Yes

@vscodebot vscodebot bot added the tasks Task system issues label Dec 28, 2017
@dbaeumer dbaeumer added the bug Issue identified by VS Code Team member as probable bug label Jan 8, 2018
@dbaeumer dbaeumer added this to the On Deck milestone Jan 8, 2018
@dbaeumer dbaeumer modified the milestones: On Deck, September 2018 Sep 24, 2018
@chrmarti chrmarti added the verified Verification succeeded label Sep 28, 2018
@chrmarti
Copy link
Contributor

Verified. Note that the above task will be run as 'xcodebuild build' oops resulting a 'command not found: xcodebuild build' error.

@vscodebot vscodebot bot locked and limited conversation to collaborators Nov 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug tasks Task system issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants