Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow alt+F4 to close window in integrated terminal on Windows Fixes #35646 #40953

Merged
merged 2 commits into from
Jan 2, 2018
Merged

Allow alt+F4 to close window in integrated terminal on Windows Fixes #35646 #40953

merged 2 commits into from
Jan 2, 2018

Conversation

usernamehw
Copy link
Contributor

@usernamehw usernamehw commented Dec 29, 2017 •
edited by Tyriar

Fixes #35646
@Tyriar

@usernamehw
Copy link
Contributor Author

usernamehw commented Dec 29, 2017 •
edited

Or is it better to use event.key === 'F4' instead of event.keyCode === 115 ? I am not sure if keyCode for F4 vary across keyboard layouts.

@Tyriar
Copy link
Member

Tyriar commented Dec 31, 2017

If key works that would be best as keyCode is deprecated 👍

@Tyriar Tyriar added this to the December 2017/January 2018 milestone Dec 31, 2017
@Tyriar Tyriar self-assigned this Dec 31, 2017
Tyriar
Tyriar approved these changes Jan 2, 2018
View reviewed changes
Copy link
Member

@Tyriar Tyriar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! ✨

@Tyriar Tyriar merged commit 2cc83dd into microsoft:master Jan 2, 2018
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Tyriar Tyriar Tyriar approved these changes

Assignees

@Tyriar Tyriar

Labels
None yet
Projects
None yet
Milestone
January 2018
Development

Successfully merging this pull request may close these issues.

Can't close vscode while integrated terminal is focused
2 participants
@usernamehw @Tyriar