Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update search viewlet with global search buffer text immediately #40955

Closed
roblourens opened this issue Dec 29, 2017 · 5 comments
Closed

Update search viewlet with global search buffer text immediately #40955

roblourens opened this issue Dec 29, 2017 · 5 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues

Comments

@roblourens
Copy link
Member

Continuation of #39609

Should we update the search viewlet text immediately when the global search buffer is changed? This would mean

  • The search viewlet text is changed every time the editor find widget is used
  • And when the window is focused, after doing a search in another file

Currently it only is updated when the input box is selected

@wprater
Copy link
Contributor

wprater commented Dec 30, 2017

Thanks for continuing this, interested to see what others think.

@wprater
Copy link
Contributor

wprater commented Dec 30, 2017

I have an issue where cmd+e places focus on the find input after its action emits. I would think the cmd+e should populate the find input fields immediately.

You see, I dont think its the same as cmd+f, its the same as the action when one hits return in the find input field, but when I press cmd+e, I do not expect any input fields to be selected or my cursor to lose its focus.

For example I want to find some matching strings and remove the lines, so I hit cmd+e to place into bugger and then I wish to remove the line Im on, cmd+g to find another occurance, remove that line, etc.

Currently, find will receive focus after cmd+e, so my workflow breaks and I have to move cursor to the editor pane again.

@roblourens
Copy link
Member Author

I think that's what #39904 is for

@wprater
Copy link
Contributor

wprater commented Dec 30, 2017

thanks for linking me back to my own issue :) for some reason I thought that one had been closed.

@roblourens
Copy link
Member Author

Will consider this part of #41156, which is to consider this experience in general.

@roblourens roblourens added the *duplicate Issue identified as a duplicate of another issue(s) label Feb 9, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) search Search widget and operation issues
Projects
None yet
Development

No branches or pull requests

2 participants