Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jsdoc comment is not expanding to multiple lines #41010

Closed
Tyriar opened this issue Jan 1, 2018 · 4 comments
Closed

jsdoc comment is not expanding to multiple lines #41010

Tyriar opened this issue Jan 1, 2018 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Milestone

Comments

@Tyriar
Copy link
Member

Tyriar commented Jan 1, 2018

In a TS file, type "/**"

screen shot 2018-01-01 at 9 45 53 am

Press enter:

screen shot 2018-01-01 at 9 46 01 am

This is what I expect (and I'm pretty sure it used to do this):

screen shot 2018-01-01 at 9 47 21 am

@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug typescript Typescript support issues labels Jan 1, 2018
@mjbvz mjbvz added this to the December 2017/January 2018 milestone Jan 2, 2018
@mjbvz mjbvz added *duplicate Issue identified as a duplicate of another issue(s) upstream Issue identified as 'upstream' component related (exists outside of VS Code) labels Jan 2, 2018
@vscodebot
Copy link

vscodebot bot commented Jan 2, 2018

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@mjbvz
Copy link
Contributor

mjbvz commented Jan 2, 2018

Duplicate of microsoft/TypeScript#20089

@vscodebot vscodebot bot closed this as completed Jan 2, 2018
@mjbvz mjbvz marked this as a duplicate of microsoft/TypeScript#20089 Jan 2, 2018
@Tyriar
Copy link
Member Author

Tyriar commented Jan 2, 2018

@mjbvz is this blocked on microsoft/TypeScript#20619?

@mjbvz
Copy link
Contributor

mjbvz commented Jan 2, 2018

No, shouldn't be. We just need a new TS 2.7 insiders build to pick up the fix

Basically TS made a change to return /** */ for jsdoc templates in invalid jsdoc locations . Previously they would only return real templates such as:

/**
 * @param foo 
 */

or undefined if the location for the request was not a valid jsdoc location.

We rely on undefined being returned as a signal that we should insert the default comment template:

/**
 *
 */

@vscodebot vscodebot bot locked and limited conversation to collaborators Feb 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug *duplicate Issue identified as a duplicate of another issue(s) typescript Typescript support issues upstream Issue identified as 'upstream' component related (exists outside of VS Code)
Projects
None yet
Development

No branches or pull requests

2 participants