[regression] workbench.files.action.showActiveFileInExplorer broken

[jrieken]

{
		"key": "shift+cmd+e",
		"command": "workbench.files.action.showActiveFileInExplorer"
	},

I have the above snippet in my keybinding.json-file and it allowed me to reveal the current file in the explorer (since I don't do that automatically). This is not working anymore.

[bpasero]

@isidorn could be a regression from your commands work?

[isidorn]

I just tried this with latest insiders on the mac and it works fine for me.
@bpasero can you also reproduce this? I checked my PR and everything looks fine around this comand
@jrieken do you have some other keybindings? Was this working yesterday and stopped working today? Does the command work if you trigger it via command palette?

[jrieken]

@isidorn These are all keybindings I have defined

// my keys
[
	{
		"key": "shift+cmd+[",
		"command": "workbench.action.openView"
	},
	{
		"key": "cmd+r",
		"command": "workbench.action.reloadWindow"
	},
	{
		"key": "alt+cmd+i",
		"command": "workbench.action.toggleDevTools"
	},
	{
		"key": "shift+cmd+i",
		"command": "_webview.openDevTools"
	},
	{
		"key": "cmd+k j",
		"command": "_generateCommandsDocumentation"
	},
	{
		"key": "shift+cmd+e",
		"command": "workbench.files.action.showActiveFileInExplorer"
	},
	{
		"key": "shift+cmd+e",
		"command": "workbench.view.explorer",
		"when": "!editorIsOpen"
	},
	{
		"key": "cmd+l c",
		"command": "extension.copyGitHubLinkToClipboard"
	},
	{
		"key": "cmd+w",
		"command": "workbench.action.closeEditorsInGroup",
		"args": null
	},
	{
		"key": "cmd+e",
		"command": "workbench.action.quickOpen"
	},
	{
		"key": "cmd+e",
		"command": "workbench.action.quickOpenNavigateNext",
		"when": "inQuickOpen"
	},
	{
		"key": "shift+cmd+e",
		"command": "workbench.action.quickOpenNavigatePrevious",
		"when": "inQuickOpen"
	},
	{
		"key": "cmd+k f",
		"command": "editor.action.format",
		"when": "editorTextFocus"
	},
	{
		"key": "cmd+k",
		"command": "workbench.action.terminal.clear",
		"when": "terminalFocus"
	},
	{
		"key": "f9",
		"command": "-sortLines.sortLines",
		"when": "editorTextFocus"
	},
	{
		"key": "ctrl+w",
		"command": "expand_region",
		"when": "editorTextFocus"
	},
	{
		"key": "ctrl+shift+w",
		"command": "undo_expand_region",
		"when": "editorTextFocus && editorHasSelection"
	},
	{
		"key": "cmd+k 1",
		"command": "editor.action.insertSnippet",
		"when": "editorTextFocus",
		"args": {
			"snippet": "console.log('${1:Here-${TM_LINE_INDEX}$2}')$0"
		}
	},
	{
		"key": "shift+escape",
		"command": "acceptSnippet"
	},
	{
		"key": "cmd+k ,",
		"command": "workbench.action.openRawDefaultSettings"
	}
]

[isidorn]

I introduced this regression with the PR.
@jrieken thanks for finding this