Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add word boundray to check markdown italic #41466

Merged
merged 2 commits into from
Jan 24, 2018
Merged

fix: add word boundray to check markdown italic #41466

merged 2 commits into from
Jan 24, 2018

Conversation

mikaoelitiana
Copy link
Contributor

fixes #40787

@@ -3318,7 +3318,7 @@
<dict>
<key>begin</key>
<string>(?x)
(\*|_)(?=\S) # Open
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please update markdown.tmLanguage.base as well. We use that file to generate this one. You can run the generator using (cd extensions/markdown; npm run update-grammar)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 3371 must be changed from
<string>(?&lt;=\S)(\1)((?!\1)|(?=\1\1))</string>
to
<string>(?&lt;=\S)(\1)((?!\1)|(?=\1\1))\b</string>

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for review. I will fix that today

@msftclas
Copy link

msftclas commented Jan 17, 2018

CLA assistant check
All CLA requirements met.

@mjbvz mjbvz added this to the January 2018 milestone Jan 24, 2018
@mjbvz mjbvz merged commit 2472a47 into microsoft:master Jan 24, 2018
@mjbvz
Copy link
Contributor

mjbvz commented Jan 24, 2018

Thanks! This will be in the next insiders build and is on track for VS Code 1.20

@mikaoelitiana
Copy link
Contributor Author

mikaoelitiana commented Jan 24, 2018 via email

@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Markdown incorrect styling in editor
4 participants