-
Notifications
You must be signed in to change notification settings - Fork 27.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add word boundray to check markdown italic #41466
Conversation
@@ -3318,7 +3318,7 @@ | |||
<dict> | |||
<key>begin</key> | |||
<string>(?x) | |||
(\*|_)(?=\S) # Open |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please update markdown.tmLanguage.base
as well. We use that file to generate this one. You can run the generator using (cd extensions/markdown; npm run update-grammar)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line 3371 must be changed from
<string>(?<=\S)(\1)((?!\1)|(?=\1\1))</string>
to
<string>(?<=\S)(\1)((?!\1)|(?=\1\1))\b</string>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for review. I will fix that today
Thanks! This will be in the next insiders build and is on track for VS Code 1.20 |
Great news!!! Thank you
Mika ANDRIANARIJAONA
mikaoelitiana@gmail.com
06 95 08 91 24
@mikaoelitiana
2018-01-24 17:41 GMT+01:00 Matt Bierner <notifications@github.com>:
… Thanks! This will be in the next insiders build and is on track for VS
Code 1.20
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#41466 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AApLa2iKziR_1I1Wb3B9pFKizlsPnsojks5tN11QgaJpZM4RapuY>
.
|
fixes #40787