Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When trigger suggest for incomplete completions, use new kind #41561

Merged
merged 1 commit into from
Jan 15, 2018

Conversation

ramya-rao-a
Copy link
Contributor

@ramya-rao-a ramya-rao-a commented Jan 13, 2018

This PR introduces a new trigger kind for the case where completion provider are asked for completions as the previous list returned was incomplete.

cc @mjbvz and @dbaeumer

@mjbvz
Copy link
Contributor

mjbvz commented Jan 13, 2018

@ramya-rao-a Code changes look good. Curious how this will be used though. Something with emmet?

@ramya-rao-a
Copy link
Contributor Author

Yes, it helps in my current exploration of integrating emmet completions in the css completion provider. The css completions are "complete" ones and the emmet completions are "incomplete". Since we can only have 1 list coming out of the LS, this makes the list "incomplete".

Knowing that the current request is for completing a previous incomplete list, lets us re-use the last completion result and only update the emmet completions. This way, we don't need to re-parse the file contents.

Other extensions can be benefitted in the same way. We know for sure the C++ completions are also of the "incomplete" kind and can use this to optimize their completion process.

@dbaeumer
Copy link
Member

Looks good to me. Ping me when merged so that I can adopt for LSP.

@jrieken jrieken merged commit 788486c into master Jan 15, 2018
@joaomoreno joaomoreno deleted the incomplete branch April 30, 2018 08:31
@github-actions github-actions bot locked and limited conversation to collaborators Mar 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants