Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a setting to configure the multi selection modifier key #41799

Closed
egamma opened this issue Jan 18, 2018 · 1 comment
Closed

Provide a setting to configure the multi selection modifier key #41799

egamma opened this issue Jan 18, 2018 · 1 comment
Assignees
Labels
feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@egamma
Copy link
Member

egamma commented Jan 18, 2018

With the new multi selection support a CTRL-Click no longer opens an editor to the side, but adds the selected item to the selection. Opening an editor to the side is now done using ALT-Click.

We should support a backward compatibility setting for users that prefer the old CTRL-Click to open an editor to the side. This is similar to the editor.multiCursorModifier.

@egamma egamma added this to the January 2018 milestone Jan 18, 2018
@egamma egamma added the feature-request Request for new features or functionality label Jan 18, 2018
@bpasero bpasero added the plan-item VS Code - planned item for upcoming label Jan 18, 2018
@bpasero
Copy link
Member

bpasero commented Jan 19, 2018

I added a new setting "workbench.multiSelectModifier": "alt" | "ctrlCmd" which controls the key to be used to add to the selection (if multi select is supported). The default will be ctrlCmd, but when you set it to alt you get back to be able to use ctrlCmd to “open to side”

@joaomoreno I had to touch the List widget for this a little bit because the multi-select handling is within the widget. I am allowing to set a new IListOptions.useAltAsMultiSelectModifier property down to the mouse controller to control this.

@isidorn fyi

To verify:
Verify in the "Open Editors" list and the "Files Explorer" tree. By default you can use Ctrl/Cmd to add items to the multi-selection and Alt to "Open to Side". If you flip the setting, you can use Alt to add items to the multi-selection and Ctrl/Cmd to "Open to Side".

@bpasero bpasero added the verification-needed Verification of issue is requested label Jan 19, 2018
@roblourens roblourens added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality plan-item VS Code - planned item for upcoming verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants