[fix-panel-auto-maximize] removes condition which contraints panelHeight

[shobhitchittora]

Closes: #41625

Checklist -

• No Lint errors
• Tests pass
• Hand tested the fix

[shobhitchittora]

@isidorn I removed the condition which was creating the problem ( as below ). Why was it added in the first place? Anything I missed?

https://github.com/Microsoft/vscode/blob/0bddf58ab12619c49cfb0cac3b24f0fa23bfe91c/src/vs/workbench/browser/layout.ts#L471

[isidorn]

@shobhitchittora thanks for the PR. The check was there if the panel got explictly maximized(using the action) that it shuold stay maximized. Though I prefer that we remove this, so your PR is fine.
However now the previousMaxPanelHeight variable is not used at all so make sure to remove it a couple of lines above.

[shobhitchittora]

@isidorn Thanks for pointing that out. Just curious! Shouldn't the unused var be flagged by eslint in the editor itself and not allow me to push? Instead It was showing up as (green underlined) -

What are your views on this?

PS: regarding the issue I also checked with triggering window.action.toggleMaximizedPanel and it works ✨.

[isidorn]

@shobhitchittora I get tslint errors the way I have vscode setup and that is how I found this. Not sure why you did not see it though

Thanks for the PR 🍻