Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keywords and Storage.types have the same color in Dark theme for Go #41822

Closed
ramya-rao-a opened this issue Jan 18, 2018 · 5 comments
Closed
Assignees
Labels
feature-request Request for new features or functionality themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@ramya-rao-a
Copy link
Contributor

From @sullyme on January 3, 2018 20:5

These are the colors in X IDE:

image

This instead in my VSCode:

image

How can I format colors of my code better?

Eg: chan and int have the same color!

Copied from original issue: microsoft/vscode-go#1439

@ramya-rao-a
Copy link
Contributor Author

From @smt923 on January 10, 2018 17:27

This isn't really an issue for this project, some vscode syntax themes have more or less color stuff, here is my vscode + vscode-go + the brilliant Dracula theme (plus I have ligatures in the font but that's unrelated)

syntax

You'll have to find another color theme that has more colors I think there's a vscode dark plus, or if you want one more like your old theme there's plenty of monokai (it looks like that one is based on monokai but I could be wrong) and monokai variant themes on the marketplace for vscode

For example, the 'Monokai' theme that I think is preinstalled looks like this:

monokai

just in case you don't know already, once you've installed a font you can go to file -> preferences -> color theme to change the theme

@ramya-rao-a
Copy link
Contributor Author

From @sullyme on January 10, 2018 18:54

Thanks a lot. That screenshot (https://user-images.githubusercontent.com/18464442/34537686-9caa0c4a-f0c9-11e7-91f7-08a72d5dfb5d.png) is from Visual Studio Code Dark+ theme which I love. Monokai is more grey... and Dracula I don't like it: too many lines.

Now I will go with Monokai. But I'm unhappy.

@ramya-rao-a
Copy link
Contributor Author

Thanks @smt93 for chiming in!

@sullyme The issue is with how the Dark theme assigns colors for the different textmate scopes which is controlled in the core VS Code

@ramya-rao-a
Copy link
Contributor Author

@aeschli

Sample code:

package main

import "fmt"

func main() {
	c := make(chan int)
	c <- 3987
	fmt.Print(<-c)
}

chan has the scope keyword and int has the scope storage.type. Same color gets assigned to both in the Dark theme.

@aeschli
Copy link
Contributor

aeschli commented Jan 22, 2018

Unfortunately 'storage.type' is used by many grammars for keywords such as var, function (e.g. in JavaScript). But I can update some of specific scopes that go uses.

@aeschli aeschli added this to the January 2018 milestone Jan 22, 2018
@aeschli aeschli added the feature-request Request for new features or functionality label Jan 22, 2018
@ramya-rao-a ramya-rao-a added the verification-needed Verification of issue is requested label Jan 30, 2018
@bpasero bpasero added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality themes Color theme issues verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants