Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing Debug type dropdown behavior #41835

Closed
gregvanl opened this issue Jan 19, 2018 · 1 comment
Closed

Confusing Debug type dropdown behavior #41835

gregvanl opened this issue Jan 19, 2018 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@gregvanl
Copy link

  • VSCode Version: 1.19.2
  • OS Version: Windows 10

The Debug configuration dropdown shows unsupported debug types (Python, Java) for Node.js apps.

Steps to Reproduce:

  1. Install the Python Extension Pack which includes the Python debugger.
  2. Start a debug session on an Node.js app without a launch.json (for example a new Express app)

You will not see the Debug type dropdown and the session is started using the in-memory Node.js launch configuration.

  1. Now install the Chrome debugger.
  2. Start a new debug session for the Node.js app.

You now see the Debug type dropdown listing: Node.js, Python, Chrome.
My guess is that now that there are two possible Node.js debuggers (Node.js and Chrome), the dropdown is shown. I don't think it should show Python since it isn't appropriate. You can also reproduce this with the Java Debug extension, if installed it is also in the dropdown but only if the Chrome debugger is installed.

  1. Uninstall the Chrome debugger and the dropdown is not shown.

If VS Code can determine that the debugger isn't the correct type, we should filter it out of the list. This behavior is also confusing as I didn't understand why sometimes the dropdown was displayed when I had multiple debuggers installed and sometimes not.

@gregvanl gregvanl added the debug Debug viewlet, configurations, breakpoints, adapter issues label Jan 19, 2018
@gregvanl
Copy link
Author

gregvanl commented Jan 19, 2018

This is problematic if the user selects the wrong Debug type as some extensions (C++, Python) write out a launch.json to the workspace rather than just use an in-memory version like the Node.js debugger.

@isidorn isidorn added this to the January 2018 milestone Jan 19, 2018
@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Jan 19, 2018
@gregvanl gregvanl added the verified Verification succeeded label Jan 22, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants