Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ERR Illegal value 0 for lineNumber #41925

Closed
bpasero opened this issue Jan 21, 2018 · 2 comments
Closed

ERR Illegal value 0 for lineNumber #41925

bpasero opened this issue Jan 21, 2018 · 2 comments
Assignees
@alexdima
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone
January 2018

Comments

@bpasero
Copy link
Member

bpasero commented Jan 21, 2018 •
edited

  • latest (macOS)
  • open a file
  • remove all text
  • save

=>

 ERR Illegal value 0 for `lineNumber`: Error: Illegal value 0 for `lineNumber`
    at TextModel.getLineContent (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/editor/common/model/textModel.js:558:23)
    at TrimFinalNewLinesParticipant.doTrimFinalNewLines (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/api/electron-browser/mainThreadSaveParticipant.js:129:37)
    at TrimFinalNewLinesParticipant.participate (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/api/electron-browser/mainThreadSaveParticipant.js:110:22)
    at file:///Users/bpasero/Development/Microsoft/monaco/out/vs/workbench/api/electron-browser/mainThreadSaveParticipant.js:261:46
    at next (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/async.js:338:46)
    at thenHandler (file:///Users/bpasero/Development/Microsoft/monaco/out/vs/base/common/async.js:346:21)
    at <anonymous>
    at process._tickCallback (internal/process/next_tick.js:109:7)
@bpasero bpasero changed the title ERR Illegal value 0 for lineNumber: Error: Illegal value 0 for lineNumber ERR Illegal value 0 for lineNumber Jan 21, 2018
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Jan 21, 2018
@raulesgalindo
Copy link

I can't replicate the bug on linux. It didn't show any error output on console.

@jrieken jrieken assigned alexdima and unassigned jrieken Jan 22, 2018
@alexdima
Copy link
Member

To reproduce, it is necessary to use "files.trimFinalNewlines": true.

@bpasero bpasero added this to the January 2018 milestone Jan 22, 2018
@bpasero bpasero added the verified Verification succeeded label Jan 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 8, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@alexdima alexdima

Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Milestone
January 2018
Development

No branches or pull requests
4 participants
@bpasero @jrieken @alexdima @raulesgalindo