Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot scroll with mousewheel if inside integrated terminal and using less/screen/vim #42254

Closed
nojvek opened this issue Jan 27, 2018 · 2 comments
Assignees
Labels
feature-request Request for new features or functionality terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verification-needed Verification of issue is requested verified Verification succeeded
Milestone

Comments

@nojvek
Copy link
Contributor

nojvek commented Jan 27, 2018

$ code --status
Version:          Code 1.19.3 (7c4205b5c6e52a53b81c69d2b2dc8a627abaa0ba, 2018-01-25T10:25:01.248Z)
OS Version:       Darwin x64 16.6.0)
  1. less somefile.txt
  2. Use mouse pad / mousewheel to scroll. Doesn't work. Key up / down works, but mousewheel doesn't

This works inside the native mac osx terminal just fine.

Basically integrated terminal needs to sends arrow keys when in alternate screen mode when mouse scrollup/scrolldown events are fired

Integrated terminal breaks usability of screen / less / vim e.t.c

@Tyriar
Copy link
Member

Tyriar commented Jan 29, 2018

Upstream issue: xtermjs/xterm.js#426

@Tyriar Tyriar added feature-request Request for new features or functionality upstream Issue identified as 'upstream' component related (exists outside of VS Code) terminal Integrated terminal issues labels Jan 29, 2018
@Tyriar Tyriar closed this as completed in 8d4d240 Jan 29, 2018
@Tyriar
Copy link
Member

Tyriar commented Jan 29, 2018

Thanks @nojvek, I've wanted this fixed for a while I just wasn't 100% sure what to do. I made it end up/down when the buffer has no scrollback (like the alt buffer).

@Tyriar Tyriar added this to the January 2018 milestone Jan 29, 2018
@Tyriar Tyriar added verification-needed Verification of issue is requested verified Verification succeeded labels Jan 29, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature-request Request for new features or functionality terminal Integrated terminal issues upstream Issue identified as 'upstream' component related (exists outside of VS Code) verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants