Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Open to Side" from context menu no longer moves focus #42295

Closed
bpasero opened this issue Jan 29, 2018 · 1 comment
Closed

"Open to Side" from context menu no longer moves focus #42295

bpasero opened this issue Jan 29, 2018 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Milestone

Comments

@bpasero
Copy link
Member

bpasero commented Jan 29, 2018

Steps to Reproduce:

  1. select "Open to Side" from context menu
  2. expect focus to move to the opened editor

=> focus remains

Compared to stable where focus moved.

@bpasero bpasero added the file-explorer Explorer widget issues label Jan 29, 2018
@bpasero bpasero added the bug Issue identified by VS Code Team member as probable bug label Jan 29, 2018
@isidorn
Copy link
Contributor

isidorn commented Jan 29, 2018

@bpasero what I see with latest out of source is that if I have no editor open and do "Open to Side" the focus nicely moves. However when you have already an editor open the focus is wrongly passed to the editor which is already open, not the newly opened one on the side.
I am nicely passing preserveFocus: false here

Forwarding to you to investigate why are you focusing the wrong editor

@isidorn isidorn assigned bpasero and unassigned isidorn Jan 29, 2018
@isidorn isidorn added this to the January 2018 milestone Jan 29, 2018
@joaomoreno joaomoreno added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug file-explorer Explorer widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants