Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download Now attempts .tar file instead of RPM with code-insiders #42311

Closed
jlmagee opened this issue Jan 29, 2018 · 6 comments
Closed

Download Now attempts .tar file instead of RPM with code-insiders #42311

jlmagee opened this issue Jan 29, 2018 · 6 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug install-update VS Code installation and upgrade system issues linux Issues with VS Code on Linux verified Verification succeeded
Milestone

Comments

@jlmagee
Copy link

jlmagee commented Jan 29, 2018

  • VSCode Version: code-insiders-1.20.0-1516692255.el7.x86_64
  • OS Version: 4.14.14-300.fc27.x86_64 Open Source VS Code #1 SMP Fri Jan 19 13:19:54 UTC 2018 x86_64 x86_64 x86_64 GNU/Linux

Steps to Reproduce:

  1. Click "Download Now" from Settings
  2. Formerly navigated to web page with RPM download button. Now attempts to download .tar file which I do not want.

Does this issue occur when all extensions are disabled?: N/A

@vscodebot vscodebot bot added the install-update VS Code installation and upgrade system issues label Jan 29, 2018
@tgilland95
Copy link

this happens to me as well, it started about 3 or four days ago.

not exactly a solution, but if your prefer the .rpm (or .deb, windows or mac install) you can just go to here and download the latest .rpm.

Again, not ideal if you were used to just clicking the update and getting redirected to the download, but it still gets you the latest update. I'm pretty new to linux and I'm not familiar with the potential benefits of a .tar over a distro specific download so I'm not sure if the change in updates behavior was intentional, but if it is I may add an alias to my shell to automate this (as I had done before the change).

@joaomoreno joaomoreno removed their assignment Jan 30, 2018
@Tyriar
Copy link
Member

Tyriar commented Jan 30, 2018

Duplicate #42190

@Tyriar Tyriar closed this as completed Jan 30, 2018
@Tyriar Tyriar added the *duplicate Issue identified as a duplicate of another issue(s) label Jan 30, 2018
@jlmagee
Copy link
Author

jlmagee commented Feb 10, 2018

@mjbvz @alexandrudima @Tyriar There is no rational indication that #42190 has anything to do with this issue. Until about 15 days ago, the "Download Now" selection from the settings button of the code-insiders UI opened the page at https://code.visualstudio.com/insiders/ from which an RPM of code-insiders could be downloaded. Now it navigates a browser to a forced download of a tar file which is not what is desired on a Fedora 26 laptop.

@Tyriar
Copy link
Member

Tyriar commented Feb 10, 2018

@jlmagee it works fine for me under Firefox/Fedora 23:

screen shot 2018-02-10 at 7 44 47 am

screen shot 2018-02-10 at 7 44 33 am

I asked @octref if any changes were made in this area and he said no. I'm going to need some more details to repro.

The non-insiders version also downloads the rpm correctly.

@jlmagee
Copy link
Author

jlmagee commented Feb 10, 2018

it downloads fine for me when clicking that button on the download page. The failure is that clicking "Downlooad Now" in this first screenshot
screenshot from 2018-02-10 12-38-00

goes directly to this tar download in the next screenshot.. Fedora 26 with Chrome Stable
screenshot from 2018-02-10 12-38-50

Hope this helps. Clicking "Download Now" formerly caused navigation to the Download page

@Tyriar Tyriar reopened this Feb 21, 2018
@Tyriar Tyriar added this to the February 2018 milestone Feb 21, 2018
@Tyriar Tyriar added bug Issue identified by VS Code Team member as probable bug linux Issues with VS Code on Linux and removed *duplicate Issue identified as a duplicate of another issue(s) labels Feb 21, 2018
@Tyriar Tyriar closed this as completed in 0d350b1 Feb 21, 2018
@Tyriar
Copy link
Member

Tyriar commented Feb 21, 2018

@jlmagee just pushed the fix, thanks for the report and for bearing with me 😃

@aeschli aeschli added the verified Verification succeeded label Mar 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug install-update VS Code installation and upgrade system issues linux Issues with VS Code on Linux verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

5 participants