Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow disabling color picker #42344

Closed
tempit opened this issue Jan 29, 2018 · 2 comments
Closed

Allow disabling color picker #42344

tempit opened this issue Jan 29, 2018 · 2 comments
Assignees
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-color-picker Editor color picker widget issues feature-request Request for new features or functionality

Comments

@tempit
Copy link

tempit commented Jan 29, 2018

Use case: I'm writing an extension for a CSS preprocessor. As part of our syntax, we have imported variables. When those variables are color values, I present return a ColorInformation for them, so they get the color indicator. However, I would like to disable the color picker when hovering over the indicator, as users can't change the value of the variable.
I send an empty result for the color presentation request in this case, which prevents the color picker from changing the color, but I would like it not to open at all. Is it possible to make the color picker not open when the color presentation result is empty?

Good color picker (with presentation result, will change color on click):
image

Unwanted color picker (no presentation result, will not change value on click):
image

@rebornix rebornix added feature-request Request for new features or functionality editor-color-picker Editor color picker widget issues labels Mar 29, 2018
@rebornix
Copy link
Member

rebornix commented Sep 5, 2018

Let's track this issue in #34341, thanks for your feedback!

@rebornix rebornix added the *duplicate Issue identified as a duplicate of another issue(s) label Sep 5, 2018
@vscodebot
Copy link

vscodebot bot commented Sep 5, 2018

Thanks for creating this issue! We figured it's covering the same as another one we already have. Thus, we closed this one as a duplicate. You can search for existing issues here. See also our issue reporting guidelines.

Happy Coding!

@vscodebot vscodebot bot closed this as completed Sep 5, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Oct 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
*duplicate Issue identified as a duplicate of another issue(s) editor-color-picker Editor color picker widget issues feature-request Request for new features or functionality
Projects
None yet
Development

No branches or pull requests

2 participants