Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Settings Search Progress is very nervous #42451

Closed
alexdima opened this issue Jan 30, 2018 · 1 comment
Closed

Settings Search Progress is very nervous #42451

alexdima opened this issue Jan 30, 2018 · 1 comment
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Milestone

Comments

@alexdima
Copy link
Member

Testing #42380

  • Open settings
  • Start typing in the search box
  • Observe how nervous the progress bar is: it shows, it disappears, it starts again from the beginning, it disappears again, etc.

nervous-progress

@sandy081 sandy081 added settings-editor VS Code settings editor issues bug Issue identified by VS Code Team member as probable bug labels Jan 30, 2018
@sandy081 sandy081 added this to the January 2018 milestone Jan 30, 2018
@sandy081
Copy link
Member

sandy081 commented Jan 31, 2018

This is because, progress starts showing if the bing search is not finished in 250 ms. It looks like on an average bing search is taking 250 - 300 ms and the progress is shown for the remaining time. And bing search is triggered after waiting 200 ms between key strokes. Hence the progress is getting shown in very short intervals.

Fix is to increase the progress show time to 500ms, it means show progress only if bing takes more than 500 ms. Also 250ms while filtering is not noticeable by the user.

kapture 2018-01-31 at 19 27 10

@bpasero bpasero added the verified Verification succeeded label Feb 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug settings-editor VS Code settings editor issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants