Exception when close all working files and some are dirty

[isidorn]

• VSCode Version: 18ebb4a
• OS Version: any

Steps to Reproduce:

1. Have multiple files open in working files
2. Have at lease one of those files dirty
3. Close All Working files by clicking the close action in the working files header, notice the exception
4. I can not repro this every time, but see it regularly

edited: first exception that I now removed was caused by an unrelated issue

[bpasero]

@isidorn do you get the dialog prompting you to save dirty files before the exception or after?

[isidorn]

I get the dialog and I say 'do not save' - can not always repro, can you please try it out a couple of times

[bpasero]

I dont even know what that handler is as it seems in the extension host, moving to @jrieken / @alexandrudima

[alexdima]

@isidorn Can you reproduce without installed extensions?
Hint: "Notification handler" string is not in vscode source code.

[isidorn]

@alexandrudima I can repro it if I do not have any extensions installed

[jrieken]

@isidorn The steps don't do it for me, also the message appears nowhere in our sources. Please attach the debugger to the extension host and break on error such that we have a chance to understand this

[alexdima]

@dbaeumer Maybe you use such strings in the language protocol?

[isidorn]

@jrieken when I attach debugger to the extension host I can not seem to get it to break on this error.
I can easily repro so just drop by my table if you are interested in looking into this.

[jrieken]

@isidorn Sure you don't have PowerShell tools installed? https://github.com/PowerShell/PowerShellEditorServices/blob/9fa1feaf16d13075c02b420789bbebe9b75c122b/src/PowerShellEditorServices.Protocol/LanguageServer/TextDocument.cs#L59

[jrieken]

harding @alexandrudima assumption about the language protocol (https://github.com/Microsoft/vscode-languageserver-protocol/blob/46dd8c99166b3cbee69a54e6043b99be221d793c/README.md#L654)

[isidorn]

@jrieken I do not have powershell installed

[jrieken]

maybe tslint?

[isidorn]

I do not have any extensions installed :)
I only use open in github but I uninstalled it to try to repro this issue, and I could repro

[jrieken]

Yes you have. It's called JSON and uses the language server protocol. Moving to @dbaeumer cos this seems to come from /Users/jrieken/Code/vscode/extensions/json/server/node_modules/vscode-languageserver/lib/protocol.js

[dbaeumer]

The protocol calls a notification handler which causes an exception. The protocol on the lowest level catches the excpetion sends it back to the client which prints it to the console. There is nothing I can do better. The root cause of the exception must be fixed.

The root cause lies in the languge server. I receive an update event for a document that is already closed. The interesting question is why? But I will protect my code against it.

[dbaeumer]

This issue was moved to microsoft/vscode-languageserver-node#28

[dbaeumer]

Published 1.4.1 of the language server.