Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bat] The command set "flag=" breaks syntax highlighting #42733

Closed
DmitrySokolov opened this issue Feb 1, 2018 · 4 comments
Closed

[bat] The command set "flag=" breaks syntax highlighting #42733

DmitrySokolov opened this issue Feb 1, 2018 · 4 comments
Assignees
@aeschli
Labels
extensions Issues concerning extensions verification-needed Verification of issue is requested verified Verification succeeded
Milestone
April 2018

Comments

@DmitrySokolov
Copy link

  • VSCode Version: Code 1.19.3 (7c4205b, 2018-01-25T10:36:34.867Z)
  • OS Version: Windows_NT x64 10.0.16299
  • Extensions:
Extension Author (truncated) Version
hg mrc 1.2.3
cpptools ms- 0.14.6
cmake twx 0.0.17

(2 theme extensions excluded)

Steps to Reproduce:

  1. Create test.cmd
@echo off
setlocal
set "flag="
endlocal

exit /b 0

EXPECTED
endlocal and the rest of command are highlighted

ACTUAL
endlocal and the rest of command have the default font color

Reproduces without extensions: Yes
@vscodebot vscodebot bot added the extensions Issues concerning extensions label Feb 1, 2018
@aeschli
Copy link
Contributor

aeschli commented Feb 16, 2018

This issue was moved to mmims/language-batchfile#23

@aeschli aeschli mentioned this issue Feb 16, 2018
Closed
@aeschli aeschli closed this as completed Feb 16, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 2, 2018
@aeschli aeschli reopened this Apr 17, 2018
@aeschli
Copy link
Contributor

aeschli commented Apr 17, 2018

Fixed in mmims/language-batchfile#23, reopening to sync our grammar

@aeschli aeschli added this to the April 2018 milestone Apr 17, 2018
@aeschli
Copy link
Contributor

aeschli commented Apr 18, 2018

Updated the grammar

@aeschli aeschli closed this as completed Apr 18, 2018
@aeschli aeschli added the verification-needed Verification of issue is requested label Apr 22, 2018
@alexdima alexdima added the verified Verification succeeded label Apr 24, 2018
@alexdima
Copy link
Member

image

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aeschli aeschli

Labels
extensions Issues concerning extensions verification-needed Verification of issue is requested verified Verification succeeded
Projects
None yet
Milestone
April 2018
Development

No branches or pull requests
3 participants
@DmitrySokolov @alexdima @aeschli