Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adopt TS 2.7 for building VS Code #42853

Closed
mjbvz opened this issue Feb 2, 2018 · 2 comments · Fixed by #45348
Closed

Adopt TS 2.7 for building VS Code #42853

mjbvz opened this issue Feb 2, 2018 · 2 comments · Fixed by #45348
Assignees
@mjbvz
Labels
engineering VS Code - Build / issue tracking / etc. verified Verification succeeded
Milestone
March 2018

Comments

@mjbvz
Copy link
Contributor

mjbvz commented Feb 2, 2018

Tracks using VS Code 2.7 to build vscode.

May require a few fixes in built-in extensions that use "strict": true since TS added a few more checks here
@mjbvz mjbvz added the engineering VS Code - Build / issue tracking / etc. label Feb 2, 2018
@mjbvz mjbvz added this to the February 2018 milestone Feb 2, 2018
@mjbvz mjbvz self-assigned this Feb 2, 2018
@kieferrm kieferrm mentioned this issue Feb 16, 2018
Closed
45 tasks
@mjbvz
Copy link
Contributor Author

mjbvz commented Feb 26, 2018

Blocked by palantir/tslint#3711 Will push out to next iteration

@mjbvz mjbvz modified the milestones: February 2018, March 2018 Feb 26, 2018
@ghost
Copy link

ghost commented Mar 8, 2018 •
edited by ghost

@mjbvz I just did a fresh install in a vscode clone and don't see any tslint crashes (did see some lint failures though!)

@mjbvz mjbvz mentioned this issue Mar 9, 2018
Merged
@kieferrm kieferrm mentioned this issue Mar 13, 2018
Closed
70 tasks
@Tyriar Tyriar added the verified Verification succeeded label Mar 30, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 23, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@mjbvz mjbvz

Labels
engineering VS Code - Build / issue tracking / etc. verified Verification succeeded
Projects
None yet
Milestone
March 2018
Development

Successfully merging a pull request may close this issue.

Build with TS 2.7 mjbvz/vscode
2 participants
@Tyriar @mjbvz