Emmet - Fixing bug in toggle comment with multi cursor #42857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramya-rao-a
suggested changes
Feb 6, 2018
There was a problem hiding this comment.
Good job!
Can you add a few tests as well?
https://github.com/Microsoft/vscode/blob/master/extensions/emmet/src/test/toggleComment.test.ts
ramya-rao-a
approved these changes
Feb 8, 2018
ramya-rao-a
suggested changes
Feb 8, 2018
There was a problem hiding this comment.
@gushuro The tests around the excludeLanguages are still failing. They don't when running from VS Code, but they do fail when running ./scripts/test-integration.sh from the terminal
|
Apparently, setting the tests to modify the user global settings (instead of the workspace ones) was preventing the tests to fail when running from VS Code, but making them fail when invoking the script. Undid that change so the CI doesn't fail. |
ramya-rao-a
approved these changes
Feb 8, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #27874