Hidding a Split View does not call setVisible(false) on the view

[isidorn]

1. Set a breakpoint here
2. Using the context menu hide the OPEN EDITORS view in the explorer viewlet, notice the breakopint is not being hit
3. Using the context menu bring back the OPEN EDITORS view, notice the breakpoint being hit

I would expect the setVisible(false) to be called once a view is being hidden.
I have quite some layout optimization code which is depended on the fact if the view is hidden or not. And my optimisations do not seem to work since the view is not aware it is hidden.

[sandy081]

When a view is hidden, it will be removed from split view. When it is shown again, it will be created again and added to split view.

Hence the view has to be disposed when it is removed from the split view.

[isidorn]

I can reproduce this using the exact steps I provided in the original comment

[sandy081]

@isidorn As mentioned in comment here I am disposing the view when it is removed. So I do not think it is required to call setVisible(false) if it is getting disposed.

[isidorn]

@sandy081 ok, makes sense, sorry for the confusion. Verified it gets disposed