Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quickpick input tooltips can become out of sync with its placeholder content #43114

Closed
eamodio opened this issue Feb 7, 2018 · 1 comment
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Milestone

Comments

@eamodio
Copy link
Contributor

eamodio commented Feb 7, 2018

  • VSCode Version: 1.19
  • OS Version: Windows 10

The tooltip over the input (for the placeholder), shows the wrong content (previous content) if the quickpick is replaced with a new one.

For example, in GitLens if you open file or branch history in a quickpick and see the tooltip over the input (it should be correct), but then pick one of the commits (which will open a new quickpick), and see that the tooltip over the input will still show the previous tooltip content, not the updated content.

Does this issue occur when all extensions are disabled?: No

@bpasero bpasero self-assigned this Feb 7, 2018
@bpasero bpasero added bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues labels Feb 7, 2018
@bpasero bpasero added this to the February 2018 milestone Feb 8, 2018
@bpasero bpasero closed this as completed in 1e3b0c6 Feb 8, 2018
@bpasero
Copy link
Member

bpasero commented Feb 8, 2018

Good catch 👍

@tsalinger tsalinger added the verified Verification succeeded label Mar 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Mar 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug quick-pick Quick-pick widget issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants