Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editing the keybinding to the same value in keybinding editor should not update keybindings.json #43346

Closed
ramya-rao-a opened this issue Feb 9, 2018 · 0 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug keybindings-editor Keybinding editor issues verified Verification succeeded
Milestone

Comments

@ramya-rao-a
Copy link
Contributor

  • VSCode Version: Any
  • OS Version: Any

Steps to Reproduce:

  1. Open the keyboard shortcuts editor
  2. Edit any keybinding. When prompted, enter the same keybinding as default. I chose the keybinding for the Continue command

Expected: No changes to the "Source" of the keybinding. No changes to the keybindings.json file
Actual: The "Source" changes from "Default" to "User". The keybindings.json file gets 2 entries.

[
    {
        "key": "f5",
        "command": "workbench.action.debug.continue",
        "when": "inDebugMode"
    },
    {
        "key": "f5",
        "command": "-workbench.action.debug.continue",
        "when": "inDebugMode"
    }
]
@vscodebot vscodebot bot added the keybindings VS Code keybinding issues label Feb 9, 2018
@ramya-rao-a ramya-rao-a added keybindings-editor Keybinding editor issues and removed keybindings VS Code keybinding issues labels Feb 9, 2018
@sandy081 sandy081 added the bug Issue identified by VS Code Team member as probable bug label Feb 13, 2018
@sandy081 sandy081 added this to the February 2018 milestone Feb 13, 2018
@ramya-rao-a ramya-rao-a added the verified Verification succeeded label Mar 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 12, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug keybindings-editor Keybinding editor issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

2 participants