Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selection Highlighting on Breakpoint Line #43432

Closed
mattmcnabb opened this issue Feb 11, 2018 · 4 comments
Closed

Selection Highlighting on Breakpoint Line #43432

mattmcnabb opened this issue Feb 11, 2018 · 4 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Milestone

Comments

@mattmcnabb
Copy link

mattmcnabb commented Feb 11, 2018

When debugging, attempting to highlight text on the same line as a highlighted breakpoint, the highlight is not visible. This appears to happen only when using a light theme.

  • VSCode Version: 1.20.0
  • OS Version: Windows 10.0.16299.98
    Please see this issue in the VSCode PowerShell extension repo.
@octref octref added accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues debug Debug viewlet, configurations, breakpoints, adapter issues and removed accessibility Keyboard, mouse, ARIA, vision, screen readers (non-specific) issues labels Feb 13, 2018
@roblourens roblourens assigned isidorn and unassigned roblourens Feb 14, 2018
@isidorn
Copy link
Contributor

isidorn commented Feb 14, 2018

@mattmcnabb works fince for me. What theme are you using?
screen shot 2018-02-14 at 11 05 18

@isidorn isidorn added the info-needed Issue requires more information from poster label Feb 14, 2018
@bergmeister
Copy link

I have the problem that using the dark theme that the 2 colours (text selection and breakpoint highlighting of the line) are nearly indistinguishable. I am using the latest Insider build on WinServer 2012R2 with the PowerShell extension and default settings

@mattmcnabb
Copy link
Author

@isidorn so if I'm debugging in the PowerShell extension, notice that I get the line highlighted and also get a selection highlight on that same line:

image

Any idea what that element is? I can't seem to find how to theme that, and I'm guessing it needs to have some transparency.

@isidorn isidorn added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Feb 16, 2018
@isidorn isidorn added this to the February 2018 milestone Feb 16, 2018
@isidorn
Copy link
Contributor

isidorn commented Feb 16, 2018

@mattmcnabb I added transparency to that color. You can try it out in monday's vscode insiders and let us know if the issue is fixed for you. Thanks for reporting!

@mjbvz mjbvz added the verified Verification succeeded label Mar 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug debug Debug viewlet, configurations, breakpoints, adapter issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

6 participants