Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Git console error when started on a non-existing workspace folder #43580

Closed
aeschli opened this issue Feb 13, 2018 · 2 comments
Closed

Git console error when started on a non-existing workspace folder #43580

aeschli opened this issue Feb 13, 2018 · 2 comments
Assignees
Labels
git GIT issues under-discussion Issue is under discussion for relevance, priority, approach
Milestone

Comments

@aeschli
Copy link
Contributor

aeschli commented Feb 13, 2018

Create a workspace description where the first workspace folder doesn't exist

{
	"folders": [
		{
			"path": "../bla-bla"
		}
	],
	"settings": {
	}
}

Check the console:
[Extension Host] rejected promise not handled within 1 second (at Console.originalConsole.(anonymous function) [as warn] (/home/aeschli/workspaces/vscode/extensions/git/node_modules/diagnostic-channel-publishers/dist/src/console.pub.js:42:39))

@joaomoreno
Copy link
Member

@aeschli This feels very wrong to me. This should be handled somewhere above. Otherwise, you're gonna need every extension to do fs.exists. IMO the git extension shouldn't even be activated if the folder doesn't exist.

@joaomoreno joaomoreno reopened this Feb 14, 2018
@joaomoreno joaomoreno added the under-discussion Issue is under discussion for relevance, priority, approach label Feb 14, 2018
@joaomoreno joaomoreno added this to the February 2018 milestone Feb 14, 2018
@joaomoreno joaomoreno added the git GIT issues label Feb 14, 2018
@joaomoreno
Copy link
Member

cc @bpasero

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
git GIT issues under-discussion Issue is under discussion for relevance, priority, approach
Projects
None yet
Development

No branches or pull requests

2 participants