Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double color boxes appear inside style blocks in html files in 1.21 #43628

Closed
ramya-rao-a opened this issue Feb 14, 2018 · 2 comments
Closed
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@ramya-rao-a
Copy link
Contributor

  • VSCode Version: 1.21 Insiders
  • OS Version: Windows and Mac, didnt try Linux

Steps to Reproduce:

  1. Have the below content in an html file

<style>
    .foo {

    }
</style>
  1. Inside the .foo rule type c
  2. First suggestion would be color: #000 from emmet, select it

Expected: color: #000 with 1 color box
Actual: color: #000 with 2 color box

image

Does this issue occur when all extensions are disabled?: Yes

@ramya-rao-a ramya-rao-a changed the title Double color boxes appear inside style blocks in html files Double color boxes appear inside style blocks in html files in 1.21 Feb 14, 2018
@rebornix
Copy link
Member

@aeschli I found both HTML extension and LSP registered the document color provider, so we need to delete them from HTML extension. Not sure if CSS will run into the same issue.

@rebornix rebornix removed their assignment Feb 15, 2018
@aeschli aeschli added the bug Issue identified by VS Code Team member as probable bug label Feb 15, 2018
@aeschli aeschli added this to the February 2018 milestone Feb 15, 2018
@aeschli
Copy link
Contributor

aeschli commented Feb 15, 2018

Thanks @ramya-rao-a @rebornix, I forgot to remove the client registration.

@ramya-rao-a ramya-rao-a added the verified Verification succeeded label Mar 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 2, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

3 participants