Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrated Terminal Opens files in Preview Mode #43856

Closed
akras-apixio opened this issue Feb 16, 2018 · 2 comments
Closed

Integrated Terminal Opens files in Preview Mode #43856

akras-apixio opened this issue Feb 16, 2018 · 2 comments
Assignees
Milestone

Comments

@akras-apixio
Copy link

  • VSCode Version: 1.20.1
  • OS Version: OS X 10.11.16

When using integrated terminal, follow links open up in preview mode (one at a time) even though I have "workbench.editor.enablePreviewFromQuickOpen": false, in my settings. I expected this to work for integrated terminal, and if not to have a similar option for it.

Steps to Reproduce:

  1. git grep for something in integrated terminal
  2. Cmd + click to follow 2 or more links
  3. Only 1 file will open at a time, unless file heading is double clicked (or something like that).

Does this issue occur when all extensions are disabled?: Yes

@mjbvz mjbvz assigned mjbvz and bpasero and unassigned mjbvz Feb 16, 2018
@bpasero
Copy link
Member

bpasero commented Feb 17, 2018

@akras-apixio you can disable this globally via "workbench.editor.enablePreview": false, but I let @Tyriar decide if we want a setting only for the terminal.

@bpasero bpasero assigned Tyriar and unassigned bpasero Feb 17, 2018
@Tyriar Tyriar closed this as completed in 3162acc Feb 17, 2018
@Tyriar
Copy link
Member

Tyriar commented Feb 17, 2018

I switched to pin the editors by default as this was the intent when I implemented the feature.

@Tyriar Tyriar added this to the February 2018 milestone Feb 17, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 3, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants