Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot revert file via command palette #43983

Closed
diminutivesloop opened this issue Feb 19, 2018 · 2 comments
Closed

Cannot revert file via command palette #43983

diminutivesloop opened this issue Feb 19, 2018 · 2 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Milestone

Comments

@diminutivesloop
Copy link
Contributor

Issue Type

Bug

Description

  1. Open a file.
  2. Edit the file without saving.
  3. Open the command palette (ctrl+shift+p) and select the "File: Revert File" command.

Result: The unsaved file edits are not discarded. Note that this same operation succeeds when performed via the application menu (File > Revert File).

VS Code Info

VS Code version: Code 1.20.1 (f88bbf9, 2018-02-13T15:34:36.336Z)
OS version: Windows_NT x64 6.1.7601

System Info
Item Value
CPUs Intel(R) Core(TM) i7-4930MX CPU @ 3.00GHz (8 x 3192)
Memory (System) 31.94GB (17.95GB free)
Process Argv C:\Program Files\Microsoft VS Code\Code.exe
Screen Reader no
VM 0%
Extensions (14)
Extension Author (truncated) Version
rainbow-brackets 2gu 0.0.6
project-manager ale 0.24.0
find-related eam 0.6.0
gitlens eam 8.0.1
tslint eg2 1.0.28
vscode-npm-script eg2 0.3.3
vscode-ghc-mod hoo 1.2.0
hoogle-vscode jca 0.0.4
language-haskell jus 2.4.0
vscode-duplicate mrm 1.2.0
debugger-for-chrome msj 4.1.0
code-settings-sync Sha 2.8.7
vscode-quick-scope ska 0.1.3
vim vsc 0.10.13

(1 theme extensions excluded)

Reproduces without extensions
@bpasero bpasero assigned isidorn and unassigned bpasero Feb 20, 2018
@bpasero
Copy link
Member

bpasero commented Feb 20, 2018

@isidorn looks like a regression

@isidorn isidorn added the bug Issue identified by VS Code Team member as probable bug label Feb 20, 2018
@isidorn isidorn added this to the February 2018 milestone Feb 20, 2018
@isidorn
Copy link
Contributor

isidorn commented Feb 20, 2018

@diminutivesloop thanks for reporting, you can find the fix in the vscode insiders from tomorrow

@jrieken jrieken added the verified Verification succeeded label Mar 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 6, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants