Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

markdown does not show images as of latest (1.21.0-insiders) version #44039

Closed
buffos opened this issue Feb 20, 2018 · 8 comments
Closed

markdown does not show images as of latest (1.21.0-insiders) version #44039

buffos opened this issue Feb 20, 2018 · 8 comments
Assignees
Labels
bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues verified Verification succeeded
Milestone

Comments

@buffos
Copy link

buffos commented Feb 20, 2018

Version 1.21.0-insider
Commit 6309a77
Date 2018-02-20T10:24:00.306Z
Shell 1.7.9
Renderer 58.0.3029.110
Node 7.9.0
Architecture x64
Windows 10

Steps to Reproduce:

  1. Open an md file that has an image tag (local or external does not matter)
  2. The image does not show

Does this issue occur when all extensions are disabled?: Yes

@vscodebot vscodebot bot added the markdown Markdown support issues label Feb 20, 2018
@mjbvz mjbvz added the info-needed Issue requires more information from poster label Feb 20, 2018
@mjbvz
Copy link
Contributor

mjbvz commented Feb 20, 2018

Can you please share the markdown source for the image?

@buffos
Copy link
Author

buffos commented Feb 20, 2018

as simple as that.
the image exists (ctrl + click on the link opens the image correctly)
image_error

@mjbvz
Copy link
Contributor

mjbvz commented Feb 20, 2018

I can't reproduce this in a workspace:

screen shot 2018-02-20 at 11 20 03 am

How did you open the markdown file? Was it part of a workspace?

@buffos
Copy link
Author

buffos commented Feb 20, 2018

No. just double click an orphan file.
I also deleted all extensions (deleted extension folder) and installed all extensions again.

The context menu was not updated. I had to "disable all extensions" and then "enable all extensions" to view the options in the context menu.

Which extension are you using for previewing the md?

@buffos
Copy link
Author

buffos commented Feb 20, 2018

I have just checked. It works inside a workspace. Not as a standalone file

@mjbvz mjbvz added bug Issue identified by VS Code Team member as probable bug and removed info-needed Issue requires more information from poster labels Feb 20, 2018
@mjbvz mjbvz added this to the February 2018 milestone Feb 20, 2018
@mjbvz
Copy link
Contributor

mjbvz commented Feb 20, 2018

Just the built-in one

This makes sense now. I recently disallowed webviews (like the markdown preview) from loading local files outside of the current workspace for security reasons. In the case where you have no workspace open, we probably want to treat the markdown file's folder as the implicit workspace and allow loading images file from there

@mjbvz mjbvz closed this as completed in 2d1f6d4 Feb 21, 2018
@jrieken jrieken added the verified Verification succeeded label Mar 1, 2018
@timotei
Copy link

timotei commented Mar 8, 2018

@mjbvz I am using the following VSCode version:

2018-03-09 01_19_49-visual studio code

It seems if I open directly a .md file it won't show local images, that are for example near the .MD file. IMO we should just do that by default.

@mjbvz
Copy link
Contributor

mjbvz commented Mar 8, 2018

@timotei See #45155. Should be fixed in 1.22.0 insiders builds

@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 7, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Issue identified by VS Code Team member as probable bug markdown Markdown support issues verified Verification succeeded
Projects
None yet
Development

No branches or pull requests

4 participants