-
Notifications
You must be signed in to change notification settings - Fork 28.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bail out from launch for unresolvable variables #44411
Comments
I will add an option in the |
I suggest that the |
One complication is the fact that some debug extensions introduce variables themselves (without declaring them in the package.json) and resolve them on their end. In this case we should neither touch them nor flag them as errors. |
We will only flag as errors our pre defined list of variables. We do not touch extension introduced variables. |
I have added nice error message (can be seen in the attached commit) env variables will not throw an error if they can not be found @dbaeumer please note that I have changed this behavior for all configurationResolverService clients including Tasks. Let's try it out for a couple of days and if we decide that Tasks want it to not bail out with an error I will add an option. But first wanted to try to be consistent. |
Works for launch configs in user settings but nowhere else. Yes, in my example I was referring to a "default launch config" but the feature should work everywhere. In addition the error notification should be modal, e.g. like the following: (BTW, this is the misleading error I'm receiving when there is a typo in the variable ${workspaceRoot}; instead I would like to see your new message) |
@weinand I have pushed a change that an unkown variable also throws an error. |
@isidorn I'm not sure whether your fix for unknown variables is really a good idea: above you said
We'll have to be careful not to block any launch config that contains a variable that you cannot resolve, but which is privately used by a DA. My issue from above was actually something else: I got the impression that your bailing out for a unresolvable "${file}" would only work in a default launch config coming from the user settings, but not in a normal launch config from a launch.json. But I just tried it again and I'm no longer seeing that problem. Bottom line:
|
Makes sense.
|
Created #46870 |
Typical case:
${file}
variable for theprogram
attributeObserve: you get the follwoing error:
![2018-02-26_12-53-08](https://user-images.githubusercontent.com/1898161/36669196-59e789f0-1af4-11e8-9298-1dc356cd1faa.png)
The text was updated successfully, but these errors were encountered: