Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating VS Code app doesn't have an icon #44494

Closed
dbaeumer opened this issue Feb 27, 2018 · 2 comments
Closed

Updating VS Code app doesn't have an icon #44494

dbaeumer opened this issue Feb 27, 2018 · 2 comments
Assignees
@joaomoreno
Labels
bug Issue identified by VS Code Team member as probable bug install-update VS Code installation and upgrade system issues verified Verification succeeded windows VS Code on Windows issues
Milestone
February 2018

Comments

@dbaeumer
Copy link
Member

dbaeumer commented Feb 27, 2018 •
edited by joaomoreno

The updater app shows the default app icon in the windows task bar. It should show the VS Code icon (green for insider and blue for stable).
@joaomoreno joaomoreno added bug Issue identified by VS Code Team member as probable bug install-update VS Code installation and upgrade system issues windows VS Code on Windows issues labels Feb 27, 2018
@dbaeumer
Copy link
Member Author

Checked this morning and noticed the following:

  • insider update up as a blue icon. Should be green.
  • the app still has no icon for the upper left corner

@joaomoreno
Copy link
Member

I'm not going to have a separate icon per flavour. We do the same for the CodeHelper.exe.

The window icon is interesting.

@joaomoreno joaomoreno reopened this Feb 28, 2018
@dbaeumer dbaeumer added the verified Verification succeeded label Mar 2, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 14, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joaomoreno joaomoreno

Labels
bug Issue identified by VS Code Team member as probable bug install-update VS Code installation and upgrade system issues verified Verification succeeded windows VS Code on Windows issues
Projects
None yet
Milestone
February 2018
Development

No branches or pull requests
2 participants
@joaomoreno @dbaeumer