Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Editor title is not centred in centered layout #44499

Closed
sandy081 opened this issue Feb 27, 2018 · 3 comments
Closed

Editor title is not centred in centered layout #44499

sandy081 opened this issue Feb 27, 2018 · 3 comments
Assignees
Labels
polish Cleanup and polish issue
Milestone

Comments

@sandy081
Copy link
Member

Testing #44127

image

@sandy081 sandy081 added the polish Cleanup and polish issue label Feb 27, 2018
@isidorn isidorn added this to the February 2018 milestone Feb 27, 2018
@isidorn
Copy link
Contributor

isidorn commented Mar 1, 2018

Not so trivial to do with flex box, since currently I am centering that item using flex. However it is centered relative to the title area (ignoring the actions to the right).
What I need here is cenering relative to the parent.
The only solution I see is doing flex magic on the parent, however there I failed to understand how to tell flex, first element in center, second all the way to the right.

Advice on how to solve this is welcome. @joaomoreno @bpasero

found some ugly solutinos https://stackoverflow.com/questions/33444666/how-to-center-align-one-flex-item-and-right-align-another-using-flexbox

@isidorn isidorn modified the milestones: February 2018, On Deck Mar 1, 2018
@joaomoreno
Copy link
Member

joaomoreno commented Mar 1, 2018

Not sure you can pull this off without floating the actions to the right.

I keep my yesterday's position: REMOVE IT!

@isidorn
Copy link
Contributor

isidorn commented Mar 1, 2018

yeah agree. This will be fixed as part of #44593

@isidorn isidorn closed this as completed Mar 1, 2018
@vscodebot vscodebot bot locked and limited conversation to collaborators Apr 15, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
polish Cleanup and polish issue
Projects
None yet
Development

No branches or pull requests

3 participants